Repository navigation
fix(resume): classify historical Planfile validation errors separately from canonical admission failures (ticket-132) - #157
Merged
ifuri-validator-agent[bot] merged 1 commit intoOct 28, 2026
Conversation
…y from canonical admission failures (ticket-132)
![ifuri-validator-agent[bot]](https://avatars.githubusercontent.com/in/4344831?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Validator approval after policy checks for exact head 6bd52f05474101cf5c24e9b8f546aedb29dee870.
Ticket: ticket-132
Correlation ID: local-semcod-monag-pr-157-ticket-132
Model: gemini/gemini-3.8-flash
Reviewed diff chunks: 3
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 3 diff chunk(s). Chunk 1 introduces PlanfileDiagnostic subclassing str for backwards-compatible diagnostic metadata tracking along with diagnostic parsing helpers in resume.py, plus the corresponding project ticket documentation. All required checks have passed. | Implements classification of Planfile diagnostics into canonical blocking errors and historical warnings, distinguishing unchanged stale/inherited copies from active or canonical validation failures. Test coverage verifies the expected acceptance behavior and blocking criteria. | The test additions in tests/test_resume.py thoroughly verify the diagnostic classification logic, ensuring changed peer files and unresolved collisions remain blocking while unchanged historical snapshots downgrade to non-blocking diagnostics without breaking JSON serialization, markdown formatting, or export compatibility. Required checks have passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: c135615dbd07c3cc77a575dc12000d63d292ab40...6bd52f05474101cf5c24e9b8f546aedb29dee870
Change digest: b0bdef5c2efcbc95a96674016b2f197dfec6c93771f0cd471538840564f890d0
Score: 52/100 (L), estimated 61 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":480,"base_sha":"c135615dbd07c3cc77a575dc12000d63d292ab40","binary_files":0,"categories":{"code":1,"configuration":1,"docs":2,"tests":1},"change_digest":"b0bdef5c2efcbc95a96674016b2f197dfec6c93771f0cd471538840564f890d0","comparison":"c135615dbd07c3cc77a575dc12000d63d292ab40...6bd52f05474101cf5c24e9b8f546aedb29dee870","deletions":8,"file_count":5,"files":["project/TICKETS.md","project/ticket-132/README.md","project/ticket-132/intent.json","src/monag/resume.py","tests/test_resume.py"],"head_sha":"6bd52f05474101cf5c24e9b8f546aedb29dee870","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":3,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":61,"within_budget":false},"impact":{"components":["project","semcod","src/monag","tests"],"files":["project/TICKETS.md","project/ticket-132/README.md","project/ticket-132/intent.json","semcod/monag","src/monag/resume.py","tests/test_resume.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":52,"split":{"parts":[{"estimated_minutes":13,"name":"Implement project","scope":["project"]},{"estimated_minutes":13,"name":"Implement semcod","scope":["semcod"]},{"estimated_minutes":13,"name":"Implement src/monag","scope":["src/monag"]},{"estimated_minutes":13,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-132"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-132: fix(resume): classify historical Planfile validation errors separately from canonical admission failures (ticket-132)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 61m</text></svg>DECISION D-132-4265
TICKET ticket-132
HEAD_SHA 6bd52f05474101cf5c24e9b8f546aedb29dee870
CORRELATION_ID local-semcod-monag-pr-157-ticket-132
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / remote lifecycle=PASS","governance / enforce=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","governance / remote lifecycle","governance / enforce"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/monag","pull_request":157,"head_sha":"6bd52f05474101cf5c24e9b8f546aedb29dee870","base_sha":"c135615dbd07c3cc77a575dc12000d63d292ab40","diff_sha256":"f61bcd13fe9babe0fa0c0dfdf2e8ad1ab8aa9f19a1a6abf6285f3a0933c31c24"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-132/README.md","project/ticket-132/intent.json","src/monag/resume.py","tests/test_resume.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"c135615dbd07c3cc77a575dc12000d63d292ab40","head_sha":"6bd52f05474101cf5c24e9b8f546aedb29dee870","change_digest":"b0bdef5c2efcbc95a96674016b2f197dfec6c93771f0cd471538840564f890d0","score":52,"complexity":"L","estimated_minutes":61,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "gemini/gemini-3.8-flash"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
ifuri-validator-agent
Bot
deleted the
ticket/132-coding-agent-plf-20344
branch
October 28, 2026 09:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155
semcod/monag:f7230af7b9f523a8:PLF-034(PLF-20344)ticket-132src/monag/resume.pyby source authority, changed-state, and admission reconciliation so unchanged noncanonical or historical copies yield explicithistorical_diagnosticsandcomplete: Truecanonical readiness, while malformed canonical data, changed peer stores, unresolved identities, and conflicts remain blocking admission errors.